Skip to content

Commit

Permalink
NEXT-22737 - Improve setting snippet e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@sydinh
sydinh committed Feb 21, 2023
1 parent 416be6b commit ec700c1
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 136 deletions.
6 changes: 6 additions & 0 deletions changelog/_unreleased/2023-02-20-improve-setting-snippet-e2e-tests.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: Improve setting snippet e2e tests
issue: NEXT-22737
---
# Administration
* Changed `sw-settings-snippets/crud.cy.js` to get rid of the quarantined tests for the component itself
156 changes: 20 additions & 136 deletions tests/e2e/cypress/e2e/administration/settings/sw-settings-snippets/crud.cy.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ describe('Snippets: Test crud operations', () => {
});
});

it('@settings: create, read and delete snippets', { tags: ['pa-system-settings'] }, () => {
it('@settings: create, read, update and delete snippet', { tags: ['pa-system-settings'] }, () => {
const page = new SnippetPageObject();

cy.intercept({
url: `${Cypress.env('apiPath')}/_action/snippet-set`,
method: 'post',
}).as('searchResultCall');

// Open snippet set
cy.log('Open a snippet set');
cy.get(`${page.elements.gridRow}--1 .sw-field__checkbox input`).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
Expand All @@ -51,7 +51,7 @@ describe('Snippets: Test crud operations', () => {
cy.get(page.elements.editSetAction).click();
cy.contains(page.elements.smartBarHeader, 'Snippets of "BASE en-GB"');

// Create snippet': (browser) => {
cy.log('Create a new snippet');
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get(page.elements.primaryButton).click();
Expand All @@ -61,7 +61,7 @@ describe('Snippets: Test crud operations', () => {
en: 'Blach',
});

// Open all snippet sets
cy.log('Open all snippet sets');
cy.get(page.elements.smartBarBack).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
Expand All @@ -71,54 +71,10 @@ describe('Snippets: Test crud operations', () => {
cy.get('.sw-loader').should('not.exist');
page.openAllSnippetSets();

// Filter for and verify snippet to be deleted
page.filterSnippets('a.Woodech');
cy.wait('@searchResultCall').its('response.statusCode').should('equal', 200);
cy.get(`${page.elements.dataGridRow}--0`)
.should('be.visible')
.contains('a.Woodech');

// Delete snippet
cy.clickContextMenuItem(
`${page.elements.contextMenu}-item--danger`,
page.elements.contextMenuButton,
`${page.elements.dataGridRow}--0`,
);
cy.contains(`${page.elements.modal}__body`, 'Are you sure you want to delete the snippets');

cy.get(`${page.elements.modalFooter} button${page.elements.dangerButton}`).click();
cy.get(page.elements.modal).should('not.exist');
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');

cy.get(`${page.elements.dataGridRow}--0`).should('not.contain', 'a.Woodech');
});

it('@settings: update and read snippets', { tags: ['pa-system-settings', 'quarantined'] }, () => {
const page = new SnippetPageObject();

cy.intercept({
url: `${Cypress.env('apiPath')}/_action/snippet-set`,
method: 'post',
}).as('searchResultCall');

// Open snippet set
cy.get(`${page.elements.gridRow}--1 .sw-field__checkbox input`).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get(page.elements.editSetAction).should('be.enabled');

cy.get(page.elements.editSetAction).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.contains(page.elements.smartBarHeader, 'Snippets of "BASE en-GB"');

// Edit snippet
cy.log('Edit snippet');
cy.wait('@searchResultCall').its('response.statusCode').should('equal', 200);
cy.get(`${page.elements.dataGridRow}--0`)
.should('be.visible')
.contains('aWonderful.customSnip');
.contains('a.Woodech');

cy.clickContextMenuItem(
'.sw-settings-snippet-list__edit-action',
Expand All @@ -127,115 +83,43 @@ describe('Snippets: Test crud operations', () => {
);
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.contains(page.elements.smartBarHeader, 'a.Woodech');

cy.contains(page.elements.smartBarHeader, 'aWonderful.customSnip');
// sometimes vue renders really slow placeholder values and intercepts our typing… so we ensure that vue filled that value before
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]')
.should('not.have.value', '');
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]')
.clear();
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]').clear()
.type('Mine yours theirs');
cy.get(page.elements.snippetSaveAction).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get('.icon--regular-checkmark-xs').should('be.visible');
cy.get(page.elements.smartBarBack).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');

// check if it was saved
cy.get(`${page.elements.dataGridRow}--0`)
.should('be.visible')
.contains('Mine yours theirs');
});

it('@settings: update, read, reset snippets', { tags: ['pa-system-settings', 'quarantined'] }, () => {
const page = new SnippetPageObject();

cy.intercept({
url: `${Cypress.env('apiPath')}/_action/snippet-set`,
method: 'post',
}).as('searchResultCall');

// Open snippet set
cy.get(`${page.elements.gridRow}--1 .sw-field__checkbox input`).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get(page.elements.editSetAction).should('be.enabled');

cy.get(page.elements.editSetAction).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.contains(page.elements.smartBarHeader, 'Snippets of "BASE en-GB"');

// Search for snippet
cy.log('Search for snippet');
cy.get('.sw-search-bar__input').type('account.addressCreateBtn').should('have.value', 'account.addressCreateBtn');

cy.wait('@searchResultCall').its('response.statusCode').should('equal', 200);
cy.url().should('include', encodeURI('account.addressCreateBtn'));

cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');

// Edit snippet
cy.log('Edit snippet');
cy.wait('@searchResultCall').its('response.statusCode').should('equal', 200);
cy.get(`${page.elements.dataGridRow}--0`)
.should('be.visible')
.contains('account.addressCreateBtn');

cy.clickContextMenuItem(
'.sw-settings-snippet-list__edit-action',
page.elements.contextMenuButton,
`${page.elements.dataGridRow}--0`,
);
cy.contains(page.elements.smartBarHeader, 'account.addressCreateBtn');
// sometimes vue renders really slow placeholder values and intercepts our typing… so we ensure that vue filled that value before
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]')
.should('not.have.value', '');
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]')
.clear();
cy.get('.sw-settings-snippet-detail__translation-field--0 input[name=sw-field--snippet-value]')
.clear()
.type('Foo');
cy.get('.sw-settings-snippet-detail__translation-field--1 input[name=sw-field--snippet-value]')
.type('Mine yours theirs');
.clear()
.type('Bar');
cy.get(page.elements.snippetSaveAction).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get('.icon--regular-checkmark-xs').should('be.visible');
cy.get(page.elements.smartBarBack).click();
cy.get(page.elements.smartBarBack).click();
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');


// Reset snippet
cy.log('Reset snippet');
page.openAllSnippetSets();
cy.get('.sw-search-bar__input').typeAndCheckSearchField('account.addressCreateBtn');
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');
cy.get(`${page.elements.dataGridRow}--0`)
.should('be.visible')
.contains('Mine yours theirs');

.should('contain', 'Foo')
.and('contain', 'Bar');

cy.log('Delete a snippet');
cy.clickContextMenuItem(
`${page.elements.contextMenu}-item--danger`,
page.elements.contextMenuButton,
`${page.elements.dataGridRow}--0`,
);

cy.get(':nth-child(1) > .sw-grid__cell-content').click();
cy.get('.sw-modal').should('be.visible');
cy.get('.sw-button--danger').click();
cy.get('.sw-modal').should('not.exist');

cy.get('.sw-button--danger > .sw-button__content').should('not.be.disabled');
cy.get('.sw-button--danger > .sw-button__content').click();

// Check that it got reset
cy.get('.sw-skeleton').should('not.exist');
cy.get('.sw-loader').should('not.exist');

cy.get(`${page.elements.dataGridRow}--0`).should('not.contain', 'Mine yours theirs');
cy.get(`${page.elements.dataGridRow}--0`).should('contain', 'Add address');
cy.get(`${page.elements.dataGridRow}--0`)
.should('not.contain', 'Foo')
.and('not.contain', 'Bar');
});
});

0 comments on commit ec700c1

Please sign in to comment.