Skip to content

Commit

Permalink
[FLINK-2509] [hotfix] Address pull request comments for ClassLoaderUtils
Browse files Browse the repository at this point in the history
Correcting commit, because the wrong commit was pushed earlier.
  • Loading branch information
StephanEwen committed Aug 14, 2015
1 parent 26c6447 commit 4cc8d66
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ public void testWithURLClassLoader() {
assertTrue(info.indexOf(validJar.getAbsolutePath() + "' (valid") > 0);
assertTrue(info.indexOf(invalidJar.getAbsolutePath() + "' (invalid JAR") > 0);
assertTrue(info.indexOf(nonExisting.getAbsolutePath() + "' (missing") > 0);

System.out.println(info);
}
catch (Exception e) {
e.printStackTrace();
Expand All @@ -107,7 +105,6 @@ public void testWithURLClassLoader() {
@Test
public void testWithAppClassLoader() {
try {
// must return something when invoked with 'null'
String result = ClassLoaderUtil.getUserCodeClassLoaderInfo(ClassLoader.getSystemClassLoader());
assertTrue(result.toLowerCase().contains("system classloader"));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ public <T> T getStreamOperator(ClassLoader cl) {
String exceptionMessage = "Cannot load user class: " + e.getMessage()
+ "\nClassLoader info: " + classLoaderInfo +
(loadableDoubleCheck ?
"Class was actually found in classloader - deserialization issue." :
"Class not resolveable through given classloader.");
"\nClass was actually found in classloader - deserialization issue." :
"\nClass not resolvable through given classloader.");

throw new StreamTaskException(exceptionMessage);
}
Expand Down

0 comments on commit 4cc8d66

Please sign in to comment.