Vary current and temperature in "parameter comparison"
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 603 591 -12
=========================================
- Hits 603 591 -12
Continue to review full report at Codecov.
|
rtimms
approved these changes
Aug 11, 2021
rtimms
reviewed
Aug 11, 2021
…sue-57-vary-current-and-temp-always
|
Now if the GIF has a size > 15728640, the bot goes ahead to create another one. Resizing the GIF more would have brought down the quality which would have made the GIF hazy. |
|
What do you mean by it creates another GIF? As in it does a new simulation in hope of the resulting GIF being smaller? |
|
Now it resizes the GIF again if the API gives an error |
rtimms
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
Closes #62
Changes / Additions
"Ambient temperature [K]"is being varied in every comparison and"Current function [A]"is being varied in all non-experiment comparisons, it made sense to generate them inconfig_generatorrather than inComparisonGenerator.ComparisonGeneratornow acceptsparamswhich also removes the need ofreply_overridesas the values are already varied inparams.tweet_textto go with these changes."Ambient temperature [K]"and"Current function [A]"fromparam_to_vary_dictas now they are varied in all the cases.