Fix: register_exception<>() fails after reinitialization of interpreter #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [1] for reference. [1] pybind#1610
This fixes pybind#1610 [1]. See previous commit for test cases and [1]. [1] pybind#1610
| if (hasattr(scope, name)) | ||
| pybind11_fail("Error during initialization: multiple incompatible " | ||
| "definitions with name \"" + std::string(name) + "\""); | ||
| scope.attr(name) = ex; |
There was a problem hiding this comment.
Side-effect: this also allows to register the same exception in multiple scopes. Do we want that? Isn't it better to error on this and tell the user to manually write scope.attr(name) = ex;?
Meanwhile, ex's scope will still refer to the old object from before the re-initialization, no? Is this safe?
| @@ -282,3 +282,55 @@ TEST_CASE("Reload module from file") { | |||
| result = module.attr("test")().cast<int>(); | |||
| REQUIRE(result == 2); | |||
| } | |||
|
|
|||
| namespace rerun_register_exception | |||
There was a problem hiding this comment.
Very minor detail: do we need this namespace here? Why did you add it?
It might be good practice, but it's also not used for the other tests, so maybe consistency is more important?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1610 for reference. Test cases for issues described therein are included.