Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy csr_matrix interop - Work in progress #2247

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PhilipDeegan
Copy link
Contributor

PR for #1665

I expect many changes, this is just to start with something, and see if tests pass.

@PhilipDeegan
Copy link
Contributor Author

if I need to use some functions in addition to
https://github.com/pybind/pybind11/blob/master/include/pybind11/numpy.h#L203

Should I update this code, or add it to another version?
I'm still wrapping my head around this function pointer mapping business, any tips are appreciated.

@PhilipDeegan
Copy link
Contributor Author

I assume the function codes are taken from here https://github.com/numpy/numpy/blob/master/numpy/core/code_generators/numpy_api.py

@PhilipDeegan
Copy link
Contributor Author

I believe the csr_matrix is a part of "scipy" rather than "numpy".

Is it acceptable to add "scipy" to the test environments?

@PhilipDeegan PhilipDeegan changed the title numpy csr_matrix interop - Work in progress scipy csr_matrix interop - Work in progress Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant