Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw dashed line #2337

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Draw dashed line #2337

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e455a15
added draw.dashed_line docs and functionality
oddbookworm Jul 22, 2023
c11294c
format and removed extra comment
oddbookworm Jul 22, 2023
8644b82
explicit cast from double to int
oddbookworm Jul 23, 2023
65fae4e
enforced odd number of segments so beginning and end are both visible…
oddbookworm Jul 23, 2023
5e4cd0b
lint
oddbookworm Jul 24, 2023
7c94766
fixed rounding in segment length and now draws partial final segment
oddbookworm Dec 23, 2023
b0140cc
rewriting draw_dashed_line and formatting
oddbookworm Dec 24, 2023
8ef9061
Merge branch 'main' of https://github.com/pygame-community/pygame-ce …
oddbookworm Dec 24, 2023
da18666
explicit casts
oddbookworm Dec 24, 2023
2c2287f
removed unused variable and cleaned up comments a bit
oddbookworm Dec 24, 2023
8f43bc2
format
oddbookworm Dec 24, 2023
fbfb354
added a test and a check for negative delay
oddbookworm Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@oddbookworm
oddbookworm committed Jul 24, 2023
commit 5e4cd0bb6c8e572cef0fb62da6f1f1146b77378e
3 changes: 1 addition & 2 deletions src_c/draw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,7 @@ dashed_line(PyObject *self, PyObject *args, PyObject *kwargs)
int dy = endy - starty;
double total_line_length = sqrt(dx * dx + dy * dy);
int number_segments = (int)total_line_length / length;
if (!(number_segments % 2))
{
if (!(number_segments % 2)) {
number_segments++;
}
double xstep = (double)dx / number_segments;
Expand Down