Fix gc/readweakvaltable races #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pygy
requested changes
Sep 24, 2018
| pkind = typ, | ||
| pattern = pt | ||
| } | ||
| cache[pt.id] = res_pt |
There was a problem hiding this comment.
You forgot to change return cache[pt.id] to return res_pt as you did above and below.
The following pattern leads to wrong behavior. ``` weakvaltable[a] = function(val) -- 1 <GC TRIGGERED> return weakvaltable[a] -- 2 ``` In case GC is triggered between lines 1 and 2, the retval would be equal to `nil`, because there are no reverences to the value between those lines. This commit fixes such patterns in the code with help of intermediate variable.
pygy
approved these changes
Sep 27, 2018
|
Great, thanks! So that would make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the possibility of the bug is low, we are facing it pretty frequently in
tarantool/graphqltests.