Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nutpie as an external sampler #7719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Mar 10, 2025

Summary

  • Fix parameter name mapping in NutPie integration (max_tree_depth → maxdepth)
  • Correctly handle InferenceData object returned by NutPie
  • Fix error in coords_and_dims_for_inferencedata function call
  • Handle progressbar parameter correctly
  • Simplify convergence checks to handle NutPie's different structure

Test plan

  • Run tests in tests/step_methods/test_external.py to verify NutPie integration works
  • Fixed parameter naming bugs with NutPie API

🤖 Generated with Claude Code


📚 Documentation preview 📚: https://pymc--7719.org.readthedocs.build/en/7719/

- Change max_tree_depth to maxdepth to match NutPie's API
- Fix coords_and_dims_for_inferencedata function call
- Handle progressbar parameter correctly
- Skip conversion to InferenceData since NutPie already returns one
- Simplify convergence checks to handle NutPie's different structure

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
@twiecki twiecki requested a review from ricardoV94 March 11, 2025 10:18
@twiecki twiecki changed the title Fix NutPie external sampler parameter mapping Implement nutpie as an external sampler Mar 22, 2025
@twiecki
Copy link
Member Author

twiecki commented Mar 22, 2025

@ricardoV94

@ricardoV94
Copy link
Member

@ricardoV94

It's on my stack :)

NUTPIE_AVAILABLE = False


class NutPie(ExternalSampler):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Nutpie. "pie" is not capitalized in the nutpie docs, anyway.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants