-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask compatibility #376
Open
BalzaniEdoardo
wants to merge
19
commits into
dev
Choose a base branch
from
dask_compatibility
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dask compatibility #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces compatibility for
pynapple
Tsd
objects with Dask arrays. Additionally, it modifies the__getattr__
method ofTsd
to expose data attributes, providing seamless access to Dask-specific functionality, such asarray.chunks
andarray.compute()
.Key Changes
1.
_load_array
Flag_load_array
boolean flag in_BaseTsd
. This flag tracks the lazy-load status of aTsd
.tsd2 = np.exp(tsd)
, the resultingTsd
should maintain the same lazy-load behavior as the original._load_array
flag, we could default lazy-loading toTrue
.2.
__getattr__
for Data AttributesTsd
(existing behavior).tsd.d
:Tsd
if possible. Otherwise, the raw result is returned.AttributeError
is raised.chunks
and methods likecompute()
, enhancing user experience when working with lazy-loaded data. The getattr will expose other attributes of zarr arrays and other types we support