Skip to content

Commit

Permalink
Use platform_python_implementation marker instead of implementation_name
Browse files Browse the repository at this point in the history
Use platform_python_implementation because it's implemented on older pip/Python versions
  • Loading branch information
sethmlarson authored Dec 2, 2020
1 parent 4742c7f commit 0c52eef
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ from setuptools import setup
setup(
...,
install_requires=[
"brotli; implementation_name == 'cpython'",
"brotlicffi; implementation_name != 'cpython'"
"brotli; platform_python_implementation == 'CPython'",
"brotlicffi; platform_python_implementation != 'CPython'"
]
)
```

```
# requirements.txt:
brotli; implementation_name == 'cpython'
brotlicffi; implementation_name != 'cpython'
brotli; platform_python_implementation == 'CPython'
brotlicffi; platform_python_implementation != 'CPython'
```

...then you can import the bindings in your project like so:
Expand Down

0 comments on commit 0c52eef

Please sign in to comment.