Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __all__ part 2 #13719

Merged
merged 9 commits into from
Mar 31, 2025
Merged

Add __all__ part 2 #13719

merged 9 commits into from
Mar 31, 2025

Conversation

donBarbos
Copy link
Contributor

only # TODO: missing from stub remained, which require some thought to solve :)

This comment has been minimized.

@donBarbos donBarbos marked this pull request as ready for review March 25, 2025 22:29

This comment has been minimized.

Copy link
Collaborator

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this.
I'll just trust stubtest for the actual content of __all__.
Great job overall, I have a few small comments.

Avasam

This comment was marked as duplicate.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam Avasam merged commit a3c8fce into python:main Mar 31, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants