Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

change email field length of signin form from 20 to 200 #36

Closed
wants to merge 1 commit into from

Conversation

ibigbug
Copy link

@ibigbug ibigbug commented May 20, 2013

No description provided.

@liuw
Copy link
Contributor

liuw commented May 20, 2013

Acked.

I checked the length in model is up to 200, so it is safe to merge this pull request.

However it would be better if the description be more specific.

@ibigbug
Copy link
Author

ibigbug commented May 20, 2013

ACK.

Obviously, email lenght > 20 would not sign in correctly.

@lepture
Copy link
Contributor

lepture commented May 20, 2013

I've updated in my local repo.

@ibigbug
Copy link
Author

ibigbug commented May 20, 2013

OK

@ibigbug ibigbug closed this May 20, 2013
@lepture
Copy link
Contributor

lepture commented May 20, 2013

@ibigbug Remember to create a new branch for every pull request.

https://github.com/pythoncn/june/blob/master/CONTRIBUTING.md#git-help

@ibigbug
Copy link
Author

ibigbug commented May 20, 2013

Why?

In fact, I created a new branch and deleted it after merge it into my own master..

@liuw
Copy link
Contributor

liuw commented May 20, 2013

@lepture This is rather a bug fix than a new feature. IMHO there is no need to open a new branch for simple fix like this.

@lepture
Copy link
Contributor

lepture commented May 20, 2013

@liuw keep the master branch the same as upstream.

@liuw
Copy link
Contributor

liuw commented May 20, 2013

@lepture we should probably discuss the workflow on Python-China? I'm kinda confused how things work now.

@lepture
Copy link
Contributor

lepture commented May 22, 2013

@liuw create a topic!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants