Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for int32_t indices in TBE training (3/N) #3372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for int32_t indices in TBE training (3/N) #3372

wants to merge 2 commits into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 14, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65925354

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 4a666fa
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/677c4e37ebcb1b0008227cd0
😎 Deploy Preview https://deploy-preview-3372--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
1f8f51d 
Summary:

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
041d8e9 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
53b139d 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
adfd19a 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
5d7b2f2 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
af8d89d 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 15, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
0b57b92 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@q10 q10 force-pushed the export-D65925354 branch from de227a9 to c888ff5 Compare December 14, 2024 22:12
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
c888ff5 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

@q10 q10 force-pushed the export-D65925354 branch from c888ff5 to fd6759f Compare December 14, 2024 22:29
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
fd6759f 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
956d14a 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
266796f 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
e6de6c2 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
95ff16f 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
71f02ee 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
e80025f 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
a22ca25 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
d5ab314 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@q10 q10 force-pushed the export-D65925354 branch from fd6759f to d5ab314 Compare January 2, 2025 20:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
c7cea93 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
a72b51c 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
a22a382 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
9965b6a 
Summary:
X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
d517a21 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
bb0e664 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@q10 q10 force-pushed the export-D65925354 branch from d5ab314 to 5dcdf09 Compare January 6, 2025 21:41
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
5dcdf09 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
7cd26c5 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
addc287 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added 2 commits January 6, 2025 13:42
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2B/N) (pytorch#3371)
3028d6f 
Summary:
X-link: facebookresearch/FBGEMM#618


X-link: facebookresearch/FBGEMM#462

- Fix `hash_size_cumsum` to be `int64_t` in `linearize_index_index_select_kernel` and `linearize_index_kernel`
- Enable more specializations for radix sort

Reviewed By: r-barnes

Differential Revision: D65923591
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
4a666fa 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
fceb80e 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@q10 q10 force-pushed the export-D65925354 branch from 5dcdf09 to 4a666fa Compare January 6, 2025 21:42
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
ee73776 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65925354

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
758b372 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
6e1ecbc 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
6dc4cb2 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
7b4aa84 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
2024965 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
b8c10ba 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
593438c 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 7, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
0d88caf 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65925354
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
@q10 @facebook-github-bot
Add support for int32_t indices in TBE training (2C/N) (pytorch#3372)
52dadfd 
Summary:
X-link: facebookresearch/FBGEMM#619

X-link: facebookresearch/FBGEMM#465


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65925354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q10 @facebook-github-bot