Setting default logging level to WARNING (#1086)

pytorch · Apr 24, 2024 · a644820 · a644820
1 parent 2104a68
commit a644820
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/pippy/debug.py b/pippy/debug.py
@@ -10,16 +10,15 @@
 #   - WARNING (default)
 #   - INFO
 #   - DEBUG
-PIPPY_VERBOSITY = os.environ.get("PIPPY_VERBOSITY")
-if PIPPY_VERBOSITY not in [None, "WARNING", "INFO", "DEBUG"]:
+PIPPY_VERBOSITY = os.getenv("PIPPY_VERBOSITY", "WARNING")
+if PIPPY_VERBOSITY not in ["WARNING", "INFO", "DEBUG"]:
     logging.warning(f"Unsupported PIPPY_VERBOSITY level: {PIPPY_VERBOSITY}")
-    PIPPY_VERBOSITY = None
+    PIPPY_VERBOSITY = "WARNING"
 
-if PIPPY_VERBOSITY:
-    logging.getLogger("pippy").setLevel(PIPPY_VERBOSITY)
-    # It seems we need to print something to make the level setting effective
-    # for child loggers. Doing it here.
-    logging.warning(f"Setting PiPPy logging level to: {PIPPY_VERBOSITY}")
+logging.getLogger("pippy").setLevel(PIPPY_VERBOSITY)
+# It seems we need to print something to make the level setting effective
+# for child loggers. Doing it here.
+logging.warning(f"Setting PiPPy logging level to: {PIPPY_VERBOSITY}")
 
 
 def friendly_debug_info(v):