Fix #pyre-strict lint error in two files and add type error comments #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1744
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53208789 |
migeed-z
added a commit
to migeed-z/executorch
that referenced
this pull request
Jan 30, 2024
…ytorch#1744) Summary: Fix #pyre-strict linting error using the PyreStrictLinter and silencing the resulting type errors using pyre -l path_to_file --output=json check | pyre-upgrade fixme Differential Revision: D53208789
migeed-z
force-pushed
the
export-D53208789
branch
from
a9b76b6 to
9c599ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53208789 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53208789 |
migeed-z
added a commit
to migeed-z/executorch
that referenced
this pull request
Jan 30, 2024
…ytorch#1744) Summary: Fix #pyre-strict linting error using the PyreStrictLinter and silencing the resulting type errors using pyre -l path_to_file --output=json check | pyre-upgrade fixme Differential Revision: D53208789
migeed-z
force-pushed
the
export-D53208789
branch
from
9c599ce to
eb48cf9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53208789 |
…ytorch#1744) Summary: Fix #pyre-strict linting error using the PyreStrictLinter and silencing the resulting type errors using pyre -l path_to_file --output=json check | pyre-upgrade fixme Differential Revision: D53208789
migeed-z
force-pushed
the
export-D53208789
branch
from
eb48cf9 to
bef5b41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53208789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix #pyre-strict linting error using the PyreStrictLinter and silencing the resulting type errors using
pyre -l path_to_file
--output=json check | pyre-upgrade fixme
Differential Revision: D53208789