Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor serialize.py #9124

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Mar 11, 2025

Stack from ghstack (oldest at bottom):

Refactor _extract_tensors out of serialize.py, simplify before serializing named_data

Differential Revision: D70752429

Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data

Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9124

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 9de6320 with merge base 94ec549 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lucylq added a commit that referenced this pull request Mar 11, 2025
Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data

Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)

ghstack-source-id: 270932484
Pull Request resolved: #9124
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70752429

Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data

Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Mar 25, 2025
Pull Request resolved: #9124

Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data
ghstack-source-id: 273798696

Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70752429

@facebook-github-bot facebook-github-bot merged commit 87d0eb9 into gh/lucylq/58/base Mar 25, 2025
78 of 83 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/lucylq/58/head branch March 25, 2025 09:23
lucylq added a commit that referenced this pull request Mar 25, 2025
Pull Request resolved: #9124

Refactor `_extract_tensors` out of serialize.py, simplify before serializing named_data
ghstack-source-id: 273798696

Differential Revision: [D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)
@lucylq lucylq mentioned this pull request Mar 25, 2025
lucylq added a commit that referenced this pull request Mar 25, 2025
Pull Request resolved: #9124

Refactor `_extract_tensors` out of serialize.py, simplify before
serializing named_data ghstack-source-id: 273798696

Differential Revision:
[D70752429](https://our.internmc.facebook.com/intern/diff/D70752429/)

### Summary
[PLEASE REMOVE] See [CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests)
for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes
#<issue-id>` line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be
the upcoming release notes, please add a "Release notes: <area>" label.
For a list of available release notes labels, check out
[CONTRIBUTING.md's Pull
Requests](https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#pull-requests).

### Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual
commands you used and note down tests that you have written if
applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants