[ET-VK] Adding all tensor packing support to split op. #9345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff updates Executorch Vulkan backend's `split` operation to support width, height and channel packed tensors. It also updates the op_registry.py file to indicate `split` operation supports all packing and adds new test cases to the cases.py file to test the operation. Differential Revision: [D71345589](https://our.internmc.facebook.com/intern/diff/D71345589/) [ghstack-poisoned]
This was referenced Mar 17, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9345
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 3322c35 with merge base 1ccc5a0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Mar 17, 2025
This diff updates Executorch Vulkan backend's `split` operation to support width, height and channel packed tensors. It also updates the op_registry.py file to indicate `split` operation supports all packing and adds new test cases to the cases.py file to test the operation. Differential Revision: [D71345589](https://our.internmc.facebook.com/intern/diff/D71345589/) ghstack-source-id: 272306677 Pull Request resolved: #9345
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71345589 |
yipjustin
approved these changes
Mar 19, 2025
This diff updates Executorch Vulkan backend's `split` operation to support width, height and channel packed tensors. It also updates the op_registry.py file to indicate `split` operation supports all packing and adds new test cases to the cases.py file to test the operation. Differential Revision: [D71345589](https://our.internmc.facebook.com/intern/diff/D71345589/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D71345589 |
facebook-github-bot
merged commit 3d9f5d5
into
gh/trivedivivek/66/base
79 of 83 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Mar 20, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9345 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#9345 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/65/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/66/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff updates Executorch Vulkan backend's
splitoperation to support width, height and channel packed tensors.It also updates the op_registry.py file to indicate
splitoperation supports all packing and adds new test cases to the cases.py file to test the operation.Differential Revision: D71345589