Reset IO for the multiple iters output accurancy #9412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: if I don't reset_io same as shiftpointer, the multi-iters send output will be incorrect Example for error <|begin_of_text|><|start_header_id|>user<|end_header_id|> what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|> 1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|> what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|> briefly! after the below diff <|begin_of_text|><|start_header_id|>user<|end_header_id|> what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|> 1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|> what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|> 1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|> Differential Revision: D71492510
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9412
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d2d24c3 with merge base e0235f0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71492510 |
|
@pytorchbot label "topic: not user facing" |
cccclai
requested review from
chunit-quic,
haowhsu-quic,
shewu-quic and
winskuo-quic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
if I don't reset_io same as shiftpointer, the multi-iters send output will be incorrect
Example for error
<|begin_of_text|><|start_header_id|>user<|end_header_id|>
what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|>
1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|>
what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|>
briefly!
after the below diff
<|begin_of_text|><|start_header_id|>user<|end_header_id|>
what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|>
1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|>
what is 1+1<|eot_id|><|start_header_id|>assistant<|end_header_id|>
1 + 1 = 1 + 1 = 2<|eot_id|><|begin_of_text|><|start_header_id|>user<|end_header_id|>
Differential Revision: D71492510