Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodMeta API to query of backends number and names #9440

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Mar 20, 2025

Add a way to learn which backends are used for a particular Method

Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9440

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5dbc59c with merge base 4e1d2e5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@shoumikhin
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@shoumikhin shoumikhin merged commit 256dfa0 into pytorch:main Mar 20, 2025
80 checks passed
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
@mergennachin
Copy link
Contributor

Hi @shoumikhin,

There's already very similar API added in #8520 and #8738

Do we need all these similar APIs - please add more context in the PR summary.

We should consolidate them and disambiguiate which ones to use.

Also the "topic: not user facing" is not appropriate -- since this is a user facing API addition.

Cc @cccclai @tarun292 , @larryliu0820 , @JacobSzwejbka

@shoumikhin
Copy link
Contributor Author

@mergennachin these apis are to query MethodMeta for the backends used for a concrete Method. I believe the apis introduced by @cccclai are to fetch all the backends registered at runtime, regardless of a particular Program or Method.

@JacobSzwejbka
Copy link
Contributor

I think the query on a single model is a reasonable addition, I agree it should have public api release notes.

I can imagine this being used once we have some support for device or for backend options

@tarun292
Copy link
Contributor

@shoumikhin yep i think when you add the api release notes for this also please add when a user should use which API. Although it's reasonably clear to us, for new users i don't think it's very clear.

@cccclai
Copy link
Contributor

cccclai commented Mar 21, 2025

This one seems helpful. The APIs I added is for the registered backend, but not the backend required from the models

DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants