-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MethodMeta API to query of backends number and names #9440
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9440
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5dbc59c with merge base 4e1d2e5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "topic: not user facing" |
Hi @shoumikhin, There's already very similar API added in #8520 and #8738 Do we need all these similar APIs - please add more context in the PR summary. We should consolidate them and disambiguiate which ones to use. Also the "topic: not user facing" is not appropriate -- since this is a user facing API addition. |
@mergennachin these apis are to query MethodMeta for the backends used for a concrete Method. I believe the apis introduced by @cccclai are to fetch all the backends registered at runtime, regardless of a particular Program or Method. |
I think the query on a single model is a reasonable addition, I agree it should have public api release notes. I can imagine this being used once we have some support for device or for backend options |
@shoumikhin yep i think when you add the api release notes for this also please add when a user should use which API. Although it's reasonably clear to us, for new users i don't think it's very clear. |
This one seems helpful. The APIs I added is for the registered backend, but not the backend required from the models |
Add a way to learn which backends are used for a particular Method