Arm backend: Make setup.sh handle unset EULA variable #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9446
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2a1ea0b with merge base 33f08c1 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
perheld
added
partner: arm
perheld
force-pushed
the
ph-setup.sh-bug
branch
from
d008c3f to
1fc363b
Compare
If setup.sh was called without --i-agree-to-the-contained-eula or with ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA unset all you would get back is the error message: "examples/arm/setup.sh: line 88: ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA: unbound variable" This is not a good error message. This commit adds handling of this variable being unset and gives a proper error message on how to accept the EULA. Change-Id: I2fd85ff136f708f91836fae32e4e402d0557fa25
perheld
force-pushed
the
ph-setup.sh-bug
branch
from
1fc363b to
2a1ea0b
Compare
digantdesai
approved these changes
Mar 21, 2025
zingo
approved these changes
Mar 21, 2025
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
If setup.sh was called without --i-agree-to-the-contained-eula or with ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA unset all you would get back is the error message: "examples/arm/setup.sh: line 88: ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA: unbound variable" This is not a good error message. This commit adds handling of this variable being unset and gives a proper error message on how to accept the EULA.
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
If setup.sh was called without --i-agree-to-the-contained-eula or with ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA unset all you would get back is the error message: "examples/arm/setup.sh: line 88: ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA: unbound variable" This is not a good error message. This commit adds handling of this variable being unset and gives a proper error message on how to accept the EULA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If setup.sh was called without --i-agree-to-the-contained-eula or with ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA unset all you would get back is the error message:
"examples/arm/setup.sh: line 88:
ARM_FVP_INSTALL_I_AGREE_TO_THE_CONTAINED_EULA: unbound variable"
This is not a good error message. This commit adds handling of this variable being unset and gives a proper error message on how to accept the EULA.
Change-Id: I2fd85ff136f708f91836fae32e4e402d0557fa25
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218