-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a CoreML inmemoryfs pybinding target #9482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9482
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 588fa40 with merge base c890809 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
approved these changes
Mar 21, 2025
8401ea6
to
3d18509
Compare
1f3966d
to
05b129a
Compare
eaddcd2
to
dc338bd
Compare
mergennachin
approved these changes
Mar 21, 2025
e6419ac
to
296af8f
Compare
f96e713
to
6c82a26
Compare
5bc0bdc
to
7e51d3a
Compare
1287a85
to
2f299ac
Compare
2f299ac
to
4c09e91
Compare
mergennachin
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
module: build/install
Issues related to the cmake and buck2 builds, and to installing ExecuTorch
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context: #9481
We now create the pybinding target for inmemoryfs. Note that the build recipe is from the wheel builder:
executorch/backends/apple/coreml/runtime/inmemoryfs/setup.py
Lines 17 to 38 in 5fdfa51
Test plan
cc @larryliu0820 @lucylq