Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: Various fixes to get per channel quantization in place #9487

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

per
Copy link
Collaborator

@per per commented Mar 21, 2025

Summary

First series of patches to enable per channel quantization

Test plan

Arm backend unit tests

cc @digantdesai @freddan80 @zingo @oscarandersson8218

@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 21, 2025
@per per requested a review from digantdesai as a code owner March 21, 2025 08:03
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9487

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 4a452b5 with merge base a6cd1dc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
per added 3 commits March 21, 2025 09:04
Change-Id: I2713cc87256d3dd1228d91e46f8eaeee5737a3cf
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I807271caffb3d70641f22d0dfc4835060aa069b2
In order to support per_channel operations, switch to using lists for
the arguments to rescale operation creators.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: If67826df631af2540a80e74584fcd6500398ceff
@per per force-pushed the per_channel_part1 branch from 791617d to 4a452b5 Compare March 21, 2025 08:04
@per per requested review from zingo and oscarandersson8218 March 21, 2025 08:35
@per
Copy link
Collaborator Author

per commented Mar 21, 2025

Unrelated failures.

@zingo
Copy link
Collaborator

zingo commented Mar 21, 2025

Fails seem unrelated

@zingo zingo merged commit 60d9de6 into pytorch:main Mar 21, 2025
160 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants