updte the return type of log_delegation_intermediate_output #9493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gasoonjia
requested review from
JacobSzwejbka,
lucylq,
swolchok and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9493
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c20bd9 with merge base 76ae537 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71591385 |
|
@pytorchbot label "topic: not user facing" |
Gasoonjia
force-pushed
the
export-D71591385
branch
from
495fa42 to
569f968
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 22, 2025
…9493) Summary: Update the return type pf event_tracer::log_intermediate_output_delegate from void to Result<bool> to: 1. indicate the filter status 2. make the error raised gracefully. The whole design can be found here pytorch#9260 Reviewed By: YIWENX14 Differential Revision: D71591385
|
This pull request was exported from Phabricator. Differential Revision: D71591385 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 22, 2025
…9493) Summary: Pull Request resolved: pytorch#9493 Update the return type pf event_tracer::log_intermediate_output_delegate from void to Result<bool> to: 1. indicate the filter status 2. make the error raised gracefully. The whole design can be found here pytorch#9260 Reviewed By: YIWENX14 Differential Revision: D71591385
Gasoonjia
force-pushed
the
export-D71591385
branch
from
569f968 to
735ada4
Compare
tarun292
approved these changes
Mar 22, 2025
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Mar 22, 2025
…9493) Summary: Update the return type pf event_tracer::log_intermediate_output_delegate from void to Result<bool> to: 1. indicate the filter status 2. make the error raised gracefully. The whole design can be found here pytorch#9260 Reviewed By: YIWENX14 Differential Revision: D71591385
Gasoonjia
force-pushed
the
export-D71591385
branch
from
735ada4 to
2eb08ad
Compare
…9493) Summary: Pull Request resolved: pytorch#9493 Update the return type pf event_tracer::log_intermediate_output_delegate from void to Result<bool> to: 1. indicate the filter status 2. make the error raised gracefully. The whole design can be found here pytorch#9260 Reviewed By: YIWENX14 Differential Revision: D71591385
|
This pull request was exported from Phabricator. Differential Revision: D71591385 |
Gasoonjia
force-pushed
the
export-D71591385
branch
from
2eb08ad to
5c20bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the return type pf event_tracer::log_intermediate_output_delegate from void to Result to:
The whole design can be found here #9260
Reviewed By: YIWENX14
Differential Revision: D71591385