Bug fix in Ethos runtime backend #9517
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9517
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e85d40c with merge base 5c5b84e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
|
@pytorchbot label "topic: not user facing" |
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 22, 2025
Summary: See the comment in source for explanation. Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
2743ff0 to
cdba9aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 22, 2025
Summary: See the comment in source for explanation. Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
cdba9aa to
a0b997c
Compare
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 22, 2025
Summary: See the comment in source for explanation. Also change the default MACs for U85 to 256, which is default on FVP SSE-320. Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
a0b997c to
2935153
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 22, 2025
Summary: See the comment in source for explanation. Also change the default MACs in U85 compile spec to 256, which is default on FVP SSE-320. Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
2935153 to
8b046a3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 22, 2025
Summary: Cortex-M is 32-bit, so pointer type in the runtime backend is also 32-bit. If the address >= 0x80000000, direct cast to uint64_t treates it as signed integer and signed extends it to 0xFFFFFFFFXXXXXXXX, which causes address validity check in Ethos driver to fail. First cast it to unsigned type uintptr_t then cast to uint64_t avoids this issue. Also change the default MACs in U85 compile spec to 256, which is default on FVP SSE-320. Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
8b046a3 to
bea155f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
zingo
approved these changes
Mar 24, 2025
limintang
force-pushed
the
export-D71658384
branch
from
bea155f to
3ace273
Compare
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 24, 2025
Summary: Cortex-M is 32-bit, so pointer type in the runtime backend is also 32-bit. If the address >= 0x80000000, direct cast to uint64_t treates it as signed integer and sign extends it to 0xFFFFFFFFXXXXXXXX, which causes address validity check in Ethos driver to fail. First cast it to unsigned type uintptr_t then cast to uint64_t avoids this issue. Also change the default MACs in U85 compile spec to 256, which is default on FVP SSE-320. Differential Revision: D71658384
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
zingo
requested changes
Mar 24, 2025
There was a problem hiding this comment.
Thanks for the fix, good find. The fix is really good but there is just a small lintrunner error that needs to be fixed to keep HEAD clean if its OK🙏
If not I can also create a new PR tomorrow with fix for both this and the lint problem, no problem. Thanks for the help.
limintang
added a commit
to limintang/executorch
that referenced
this pull request
Mar 24, 2025
Summary: Cortex-M is 32-bit, so pointer type in the runtime backend is also 32-bit. If the address >= 0x80000000, direct cast to uint64_t treates it as signed integer and sign extends it to 0xFFFFFFFFXXXXXXXX, which causes address validity check in Ethos driver to fail. First cast it to unsigned type uintptr_t then cast to uint64_t avoids this issue. Reviewed By: digantdesai Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
3ace273 to
fc77121
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
zingo
approved these changes
Mar 24, 2025
Summary: Cortex-M is 32-bit, so pointer type in the runtime backend is also 32-bit. If the address >= 0x80000000, direct cast to uint64_t treates it as signed integer and sign extends it to 0xFFFFFFFFXXXXXXXX, which causes address validity check in Ethos driver to fail. First cast it to unsigned type uintptr_t then cast to uint64_t avoids this issue. Reviewed By: digantdesai Differential Revision: D71658384
limintang
force-pushed
the
export-D71658384
branch
from
b492a22 to
e85d40c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71658384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Cortex-M is 32-bit, so pointer type in the runtime backend is also 32-bit. If the address >= 0x80000000, direct cast to uint64_t treates it as signed integer and sign extends it to 0xFFFFFFFFXXXXXXXX, which causes address validity check in Ethos driver to fail. First cast it to unsigned type uintptr_t then cast to uint64_t avoids this issue.
Differential Revision: D71658384