Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalar (single element tensor) binary ops on HiFi #9523

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary:
As titled, when introduced I used dim but I should have used numel. Fixed here.
Also need to update the quantizer for the add case, will do in a separate diff.

Differential Revision: D71667998

Summary:
As titled, when introduced I used `dim` but I should have used `numel`. Fixed here.
Also need to update the quantizer for the add case, will do in a separate diff.

Differential Revision: D71667998
@mcremon-meta mcremon-meta requested a review from tarun292 as a code owner March 22, 2025 04:21
Copy link

pytorch-bot bot commented Mar 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9523

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 6f57e08 with merge base fb24360 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71667998

Copy link
Contributor

@zonglinpeng zonglinpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch

@facebook-github-bot facebook-github-bot merged commit 88d9616 into main Mar 24, 2025
78 of 84 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D71667998 branch March 24, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants