Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android aar update and enable emulator test #9524

Merged
merged 6 commits into from
Mar 24, 2025
Merged

Android aar update and enable emulator test #9524

merged 6 commits into from
Mar 24, 2025

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Mar 22, 2025 •
edited
Loading

Fix the maven deps. Should be fbjni.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9524

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit e065b85 with merge base 90f0843 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2025
@kirklandsign kirklandsign marked this pull request as ready for review March 22, 2025 05:30
@kirklandsign kirklandsign changed the title Run android emulator test for aar Android aar update and enable emulator test Mar 22, 2025
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign requested a review from swolchok as a code owner March 24, 2025 17:15
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

swolchok
swolchok approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine if CI passes?

@kirklandsign kirklandsign merged commit 4399b23 into main Mar 24, 2025
169 of 172 checks passed
@kirklandsign kirklandsign deleted the maven branch March 24, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok approved these changes

@shoumikhin shoumikhin shoumikhin approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirklandsign @facebook-github-bot @swolchok @shoumikhin