Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update current nightly version to 2.8.0 #6442

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Update current nightly version to 2.8.0 #6442

merged 1 commit into from
Mar 19, 2025

Conversation

izaitsevfb
Copy link
Contributor

Should fix docker build verification issues, like in: https://github.com/pytorch/pytorch/actions/runs/13917778953/job/38943972867

  • In the PyTorch repo, version.txt shows 2.8.0a0 (i.e., PyTorch is now developing version 2.8.0)
  • In the test-infra repo's generate_binary_build_matrix.py, line 77 shows CURRENT_NIGHTLY_VERSION = "2.7.0"
  • Build job builds: ghcr.io/pytorch/pytorch-nightly:2.8.0.dev20250318-cuda11.8-cudnn9-devel
  • Validation job tries to pull: ghcr.io/pytorch/pytorch-nightly:2.7.0.dev20250318-cuda11.8-cudnn9-devel
  • The image doesn't exist, causing "manifest unknown" errors

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Mar 19, 2025 0:16am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
@izaitsevfb izaitsevfb requested a review from atalman March 19, 2025 00:16
atalman
atalman approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 79eb640 into main Mar 19, 2025
67 of 69 checks passed
@atalman atalman deleted the update-current-nightly-version-to-2.8.0 branch March 19, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izaitsevfb @atalman @facebook-github-bot