Enable Output Dist module when DI + Lowering is required #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71671275 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Mar 24, 2025
Summary: Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up. Differential Revision: D71671275
faran928
force-pushed
the
export-D71671275
branch
from
1aa0c1c to
dd96159
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71671275 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Mar 24, 2025
Summary: Pull Request resolved: pytorch#2846 Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up. Differential Revision: D71671275
faran928
force-pushed
the
export-D71671275
branch
2 times, most recently
from
0955496 to
4c9fd62
Compare
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Mar 25, 2025
Summary: Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up. Differential Revision: D71671275
|
This pull request was exported from Phabricator. Differential Revision: D71671275 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Mar 25, 2025
Summary: Pull Request resolved: pytorch#2846 Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up. Differential Revision: D71671275
faran928
force-pushed
the
export-D71671275
branch
from
4c9fd62 to
a9fe507
Compare
Summary: Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up. Differential Revision: D71671275
faran928
force-pushed
the
export-D71671275
branch
from
a9fe507 to
555a40b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71671275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Enable Output Dist module when DI + Lowering is required. This is mainly to handle empty or zero tensors being passed across the boundary of Intermodules and merge as DI look up results during publishing may lead to this kind of set up.
Differential Revision: D71671275