Remove test installation #709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #662 See https://docs.google.com/document/d/1ASiz0Fu3c8cCHmsbseUdulU4jfTgdwZAxvlywgXiBAU/edit for more context tl;dr: Currently the only “feasible” way to specify a sharding plan is by using the OSS planner, and using constraints. I say “feasible” because although we can manually construct a ShardingPlan/ParameterSharding, it’s quite cumbersome to do so. Additionally, users do not have the expressibility to say “I want to place this parameter on rank 0” when using planner. With this new API we can construct sharding plans in a direct way: ``` ebc = EmbeddingBagCollection(...) plan = construct_parameter_sharding_plans( ebc, { "table_0": data_parallel_sharding(), "table_1": row_wise_sharding(), "table_2": column_wise_sharding(), "table_3": column_wise_sharding(ranks=[0,1,2]), "table_4": table_row_wise_sharding(host_index=2), }, EmbeddingBagCollectionSharder() ) ebc = sharder.shard( ebc, plan ) ``` Note, that this is not intended to replace the greedy planner. Instead it allows users to shard modules without being FORCED to use planner. Users will be able to user planner in the exact same way. Having alternatives instead of planner has a couple of benefits 1. There are bugs in the planner (we should be able to shard something, but planner may have a false negative rejection) 2. Planner doesn't correctly account for new architectures/models /optimizers 3. Easier to directly use torchrec (new users don't need to understand how to use planner). ----- So I decided to use a generator function because alternative ways would require creating a new dataclass called like TableWiseConfig(row=...), and I didn't like the look of it. Having just the atomic generator functions is also nice since it doesn't couple these configs with the construct_parameter_sharding_plans Differential Revision: D39803183 fbshipit-source-id: b8cb5da632f72c809559d4a4ebcc958cd9f6f92a
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.