Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A temporary fix to windows unittests failing in INaturalistTestCase. #9007

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

GdoongMathew
Copy link
Contributor

Summary

Temporary fix issue where tmp directory couldn't be removed during testing.
https://github.com/pytorch/vision/actions/runs/14085345925

cc @NicolasHug (Not sure if this kind of temp fix is needed)

Copy link

pytorch-bot bot commented Mar 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9007

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d20e31 with merge base 309bd7a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@GdoongMathew
Copy link
Contributor Author

GdoongMathew commented Mar 31, 2025

Update:
So the root cause is because of the loader argument. The loader was stored in the INaturalist attribute before the function is being mocked, and that's why the unittests failed. Once I changed to setting the loader during __getitem__, the issue no longer exists.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @GdoongMathew

@NicolasHug NicolasHug merged commit ef4718a into pytorch:main Apr 1, 2025
58 checks passed
Copy link

github-actions bot commented Apr 1, 2025

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@GdoongMathew GdoongMathew deleted the fix/inaturalist_unittests branch April 1, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants