Skip to content

Commit

Permalink
v1.18.1
Browse files Browse the repository at this point in the history
Bug fixes
    - fix a bug where a task or pool with secrets access would be
      submitted without those secrets access rights specified
  • Loading branch information
Ricordel committed Jul 26, 2023
1 parent 2bc74a0 commit 8100470
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions QarnotCLI/QarnotCLI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<AssemblyName>qarnot</AssemblyName>
<Version>1.18.0</Version>
<Version>1.18.1</Version>
<TargetFramework>net6.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Authors>Qarnot computing</Authors>
Expand All @@ -26,7 +26,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="QarnotSDK" Version="[5.9.1]" />
<PackageReference Include="QarnotSDK" Version="[5.9.3]" />
<PackageReference Include="Timestamp" Version="[1.0.2]" />
</ItemGroup>

Expand Down
16 changes: 8 additions & 8 deletions QarnotCLI/src/CommandLauncher/ApiObjectCreator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,17 @@ private QPool CreatePool(CreateConfiguration config, QarnotSDK.Connection connec

if (config.SecretsAccessRightsByKey is not null)
{
pool.SecretAccessRights ??= new();
pool.SecretAccessRights.BySecret = config
pool.SecretsAccessRights ??= new();
pool.SecretsAccessRights.BySecret = config
.SecretsAccessRightsByKey
.Select(k => new QSecretAccessRightBySecret() { Key = k })
.ToList();
}

if (config.SecretsAccessRightsByPrefix is not null)
{
pool.SecretAccessRights ??= new();
pool.SecretAccessRights.ByPrefix = config
pool.SecretsAccessRights ??= new();
pool.SecretsAccessRights.ByPrefix = config
.SecretsAccessRightsByPrefix
.Select(p => new QSecretAccessRightByPrefix() { Prefix = p })
.ToList();
Expand Down Expand Up @@ -260,17 +260,17 @@ private async Task<QTask> CreateTask(CreateConfiguration config, QarnotSDK.Conne

if (config.SecretsAccessRightsByKey is not null)
{
task.SecretAccessRights ??= new();
task.SecretAccessRights.BySecret = config
task.SecretsAccessRights ??= new();
task.SecretsAccessRights.BySecret = config
.SecretsAccessRightsByKey
.Select(k => new QSecretAccessRightBySecret() { Key = k })
.ToList();
}

if (config.SecretsAccessRightsByPrefix is not null)
{
task.SecretAccessRights ??= new();
task.SecretAccessRights.ByPrefix = config
task.SecretsAccessRights ??= new();
task.SecretsAccessRights.ByPrefix = config
.SecretsAccessRightsByPrefix
.Select(p => new QSecretAccessRightByPrefix() { Prefix = p })
.ToList();
Expand Down

0 comments on commit 8100470

Please sign in to comment.