auth3: Remove auth_skel.c

Authentication is a very complex topic, and someone who is able to write a custom auth module turning a struct auth_usersupplied_info into a struct auth_serversupplied_info should be able to live without this skeleton module. This module also gave an example to load a secondary authentication module via a module parameter (the call to load_module()). We have abandoned this practice, and since the "auth methods" parameter has gone we don't use this anymore internally. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
qaz1045692166 · Apr 19, 2021 · 8b6c6fd · 8b6c6fd
1 parent 1a696c9
commit 8b6c6fd
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 130 deletions.
diff --git a/examples/auth/Makefile b/examples/auth/Makefile
diff --git a/examples/auth/auth_skel.c b/examples/auth/auth_skel.c
diff --git a/examples/auth/wscript_build b/examples/auth/wscript_build
diff --git a/source3/wscript b/source3/wscript
@@ -1912,7 +1912,7 @@ main() {
         default_static_modules.extend(['charset_weird'])
         default_shared_modules.extend(['perfcount_test',
                                        'vfs_skel_opaque', 'vfs_skel_transparent', 'vfs_shadow_copy_test',
-                                       'auth_skel', 'pdb_test',
+                                       'pdb_test',
                                        'vfs_fake_dfq',
                                        'gpext_security', 'gpext_registry', 'gpext_scripts'])
 

diff --git a/source3/wscript_build b/source3/wscript_build
@@ -1410,7 +1410,6 @@ bld.RECURSE('passdb')
 bld.RECURSE('rpc_server')
 bld.RECURSE('script')
 bld.RECURSE('winbindd')
-bld.RECURSE('../examples/auth')
 bld.RECURSE('../examples/libsmbclient')
 bld.RECURSE('../examples/pdb')
 bld.RECURSE('../examples/VFS')

diff --git a/testsuite/unittests/test_lib_util_modules.c b/testsuite/unittests/test_lib_util_modules.c
@@ -22,14 +22,6 @@ static int teardown(void **state)
 	return 0;
 }
 
-static void test_samba_module_probe(void **state)
-{
-	NTSTATUS status;
-
-	status = smb_probe_module("auth", "skel");
-	assert_true(NT_STATUS_IS_OK(status));
-}
-
 static void test_samba_module_probe_dummy(void **state)
 {
 	const char *module_env;
@@ -63,8 +55,6 @@ static void test_samba_module_probe_slash(void **state)
 
 int main(void) {
 	const struct CMUnitTest tests[] = {
-		cmocka_unit_test_teardown(test_samba_module_probe,
-					  teardown),
 		cmocka_unit_test_teardown(test_samba_module_probe_dummy,
 					  teardown),
 		cmocka_unit_test_teardown(test_samba_module_probe_slash,