Skip to content

Commit

Permalink
netty#7695 no need to manually release chunk during upload (netty#7696)
Browse files Browse the repository at this point in the history
Motivation:

After netty#7527 fix there is no need to manually release chunks (HttpData) during file upload as they will be released on HttpPostRequestDecoder.destroy().

Modification:

HttpUploadServer example doesn't release chunks manually (doesn't call data.release()).

Result:
Fixes netty#7695 and netty#7689
  • Loading branch information
doom369 authored and normanmaurer committed Nov 2, 2018
1 parent bde2865 commit 6fbb12e
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,8 @@ private void readHttpDataChunkByChunk() {
logger.info(" 100% (FinalSize: " + partialContent.length() + ")");
partialContent = null;
}
try {
// new value
writeHttpData(data);
} finally {
data.release();
}
// new value
writeHttpData(data);
}
}
// Check partial decoding for a FileUpload
Expand Down

0 comments on commit 6fbb12e

Please sign in to comment.