Merge pull request angular-ui#2202 from pkt-zer0/master

$stateParams reset between tests
qhlxinxin · Aug 25, 2015 · 0e557ca · 0e557ca
2 parents 9dc31c5 + 2aeb0c4
commit 0e557ca
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/state.js b/src/state.js
@@ -1461,5 +1461,5 @@ function $StateProvider(   $urlRouterProvider,   $urlMatcherFactory) {
 }
 
 angular.module('ui.router.state')
-  .value('$stateParams', {})
+  .factory('$stateParams', function () { return {}; })
   .provider('$state', $StateProvider);
diff --git a/test/stateSpec.js b/test/stateSpec.js
@@ -1490,3 +1490,18 @@ describe('state queue', function(){
     });
   });
 });
+
+describe('$stateParams', function () {
+  beforeEach(module('ui.router.state'));
+
+  it('should start empty', inject(function ($stateParams) {
+    expect($stateParams.foo).toBeUndefined();
+  }));
+  it('should allow setting values on it', inject(function ($stateParams) {
+    $stateParams.foo = 'bar';
+    expect($stateParams.foo).toBeDefined();
+  }));
+  it('should be cleared between tests', inject(function ($stateParams) {
+    expect($stateParams.foo).toBeUndefined();
+  }));
+});