Fixed a bug that mistakenly invalidate childKeyValueObservation

qianqianguo · Jun 18, 2019 · e674e83 · e674e83
1 parent 7595f41
commit e674e83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Source/Content/SegementSlideContentView.swift b/Source/Content/SegementSlideContentView.swift
@@ -122,7 +122,7 @@ extension SegementSlideContentView {
     }
 
     private func clearAllReusableViewControllers() {
-        NotificationCenter.default.post(name: SegementSlideContentView.willClearAllReusableViewControllersNotification, object: nil, userInfo: nil)
+        NotificationCenter.default.post(name: SegementSlideContentView.willClearAllReusableViewControllersNotification, object: viewController, userInfo: nil)
         for (_, value) in viewControllers {
             guard let childViewController = value as? UIViewController else { continue }
             childViewController.view.removeAllConstraints()

diff --git a/Source/General/SegementSlideViewController+setup.swift b/Source/General/SegementSlideViewController+setup.swift
@@ -70,10 +70,13 @@ extension SegementSlideViewController {
     }
 
     private func observeWillClearAllReusableViewControllersNotification() {
-        NotificationCenter.default.addObserver(self, selector: #selector(willClearAllReusableViewControllers), name: SegementSlideContentView.willClearAllReusableViewControllersNotification, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(willClearAllReusableViewControllers(_:)), name: SegementSlideContentView.willClearAllReusableViewControllersNotification, object: nil)
     }
 
-    @objc private func willClearAllReusableViewControllers() {
+    @objc private func willClearAllReusableViewControllers(_ notification: Notification) {
+        guard let object = notification.object as? SegementSlideViewController, object === self else {
+            return
+        }
         childKeyValueObservation?.invalidate()
         childKeyValueObservation = nil
     }