ovn-performance.at: Missing steps for connecting LS to LR.

The test creates 2 logical switches and connect them with a logical router. However, it didn't set the option "router-port", so the 2 LS datapaths were not connected. This results in missing test coverage for port-binding incremental processing: assume I-P has a bug and port-binding change always trigger recompute, since each HV monitors only its own datapath (i.e. HV1 -> ls1, HV2 -> ls2) then it never got notification of the other port-binding change, thus recompute is never triggered when port-binding is updated on the other datapath. With this fix, each HV's local datapaths will include both ls1 and ls2, so port-binding change notification will be received properly and unexpected recompute would be captured. Signed-off-by: Han Zhou <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
qihuaheng · Jul 10, 2019 · 89fa2a7 · 89fa2a7
1 parent 2a9679e
commit 89fa2a7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/tests/ovn-performance.at b/tests/ovn-performance.at
@@ -273,6 +273,10 @@ for i in 1 2; do
         [hv1 hv2], [lflow_run],
         [ovn-nbctl --wait=hv lsp-set-type $lsp router]
     )
+    OVN_CONTROLLER_EXPECT_HIT(
+        [hv1 hv2], [lflow_run],
+        [ovn-nbctl --wait=hv lsp-set-options $lsp router-port=$lrp]
+    )
     OVN_CONTROLLER_EXPECT_HIT(
         [hv1 hv2], [lflow_run],
         [ovn-nbctl --wait=hv lsp-set-addresses $lsp router]