-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change QIIME to Qiita [AKA Travis' playground] #25
Conversation
I think the Travis error message indicates that in order to pip install cogent, we need sphinx. I assume this should be added to setup.py? Or is this really a problem with cogent...? |
No, I think the problem is that as it is Qiita cannot support python 3.2 because it depends on other packages that do not support it. This is something that should be changed in the |
I guess this is where we gonna have that talk! There are a few options |
Assuming we can do both in less than the 50 minutes allotted, I think we On Wed, Feb 19, 2014 at 11:19 AM, Antonio Gonzalez <[email protected]
|
We can try to do both, at some point cogent is not going to be a dependency and QIIME will hopefully be 3.2 compatible... |
Given that we don't have any explicit support for 3.x we shouldn't be testing it right now, but we should in the future. Otherwise all of our tests are going to fail, in order to fix this we would need to: QIIME, pyqi, bipy, cogent, emperor and all of the packages that come installed as consequence of the dependencies be 3.x compatible. That's an awful lot of work ... |
👍 until all our dependencies are 3.x compatible |
Sounds good -- but we may want to make development on some of these On Wed, Feb 19, 2014 at 11:25 AM, josenavas [email protected]:
|
Our future selves are wise and full of joy, they'll take care of this in no time. |
Well, if we think that other projects are blocking the development of Qiita, then we should spend the code sprints in this other projects... |
They're not blocking per se, but we have been talking about Python 3 As seems to be our custom, let's table python 3 discussion for the time On Wed, Feb 19, 2014 at 11:31 AM, josenavas [email protected]:
|
We should make sure that our Qiita base code is Python 3 compatible (during code reviews), so that the only thing that is not making Qiita Python 3 compatible are the dependencies. Once they are fixed, Qiita will become Py3 compatible... |
👍 On Feb 19, 2014, at 11:46 AM, josenavas [email protected] wrote:
|
I'm not sure that's actually possible (to have Qiita python 3 compatible, but at the same time allow for dependencies to be only python 2 compatible); check out the question on this page called "I want to use Python 3, but there's this tiny library I want to use that's Python 2.x only. Do I really have to revert to using Python 2 or give up on using that library?" I guess we could write it in 3, so that we know it works, then use the 3to2 tool to back-convert it, and store both versions of the code in the repo? This seems messy, though. |
I like the first solution: Port the library to 3.x. 😆🍻🍻 |
@josenavas lol I know, right!? Ah well. My position on this whole thing is "I personally don't care about Python 3, but if we say that we are going to do it, we should be realistic about it." It seems that at this time, being realistic about it (which entails understanding exactly what it would take to actually do it) means that we shouldn't do mess with Python 3 right now. So let's just move forward with Python 2.7, unless anyone else has something to add. |
Change QIIME to Qiita [AKA Travis' playground]
@josenavas @adamrp suggest at least py3 compat constructs (e.g, |
👍 |
Cool, yeah, we should definitely do that as much as possible On Wed, Feb 19, 2014 at 3:24 PM, josenavas [email protected] wrote:
|
No description provided.