Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend changes to fix 3323 #3330

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Backend changes to fix 3323 #3330

merged 7 commits into from
Nov 17, 2023

Conversation

antgonza
Copy link
Member

No description provided.

@antgonza antgonza changed the title Fix 3323 [WIP] Fix 3323 Nov 16, 2023
@coveralls
Copy link

coveralls commented Nov 16, 2023 •
edited
Loading

Coverage Status

coverage: 92.905% (+0.02%) from 92.886%
when pulling eef7fde on antgonza:fix-3323
into a48400a on qiita-spots:dev.

@antgonza antgonza changed the title [WIP] Fix 3323 Backend changes to fix 3323 Nov 17, 2023
charles-cowart
charles-cowart requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears in order. Just a few comments.

qiita_db/support_files/patches/89.sql Show resolved Hide resolved
qiita_db/test/test_analysis.py Outdated Show resolved Hide resolved
qiita_db/test/test_processing_job.py Show resolved Hide resolved
@charles-cowart charles-cowart merged commit 9bcdf46 into qiita-spots:dev Nov 17, 2023
4 checks passed
charles-cowart added a commit that referenced this pull request Nov 17, 2023
@charles-cowart
Revert "Backend changes to fix 3323 (#3330)"
8d7aa1a 
This reverts commit 9bcdf46.
charles-cowart
charles-cowart reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@antgonza antgonza mentioned this pull request Jan 9, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-cowart charles-cowart charles-cowart requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antgonza @coveralls @charles-cowart