Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor changes after deployment #3426

Merged
merged 9 commits into from
Aug 20, 2024
Merged

minor changes after deployment #3426

merged 9 commits into from
Aug 20, 2024

Conversation

antgonza
Copy link
Member

No description provided.

@antgonza antgonza requested a review from charles-cowart July 23, 2024 21:08
charles-cowart
charles-cowart approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears in order. At first it appeared like I didn't have enough context to review the biggest change in artifact.py, but after realizing the code was simply moved downward in the code it made more sense.

@charles-cowart charles-cowart merged commit 93f5327 into qiita-spots:dev Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-cowart charles-cowart charles-cowart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antgonza @charles-cowart