Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @antgonza,
the current pplacer binary, shipped with SEPP for fragment insertion, throws segmentation faults on newer Debian systems and was already reported two years ago smirarab/sepp#121
My workaround is to make SEPP switch to a later version of pplacer, but this will write the produces placements with a different field order. Considering the qiita archive, I fear that this would produce new placements which are incompatible with the db content :-/
One SEPP run produces a set of placements and fortunately, this file also reports field order like here:
qp-deblur/support_files/sepp/placements.json
Lines 4603 to 4607 in efd59e3
I therefore came up with this PR, that should ensure that placements are read and stored in a specified field order, i.e. rearranges if necessary.
Unfortunately, the current tests fail - but I think this is not due to this PR but a more general issue, see #67