Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable placement order #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Stable placement order #68

wants to merge 3 commits into from

Conversation

sjanssen2
Copy link
Collaborator

Hi @antgonza,

the current pplacer binary, shipped with SEPP for fragment insertion, throws segmentation faults on newer Debian systems and was already reported two years ago smirarab/sepp#121

My workaround is to make SEPP switch to a later version of pplacer, but this will write the produces placements with a different field order. Considering the qiita archive, I fear that this would produce new placements which are incompatible with the db content :-/

One SEPP run produces a set of placements and fortunately, this file also reports field order like here:

"version": 1, "fields": ["edge_num",
"likelihood",
"like_weight_ratio",
"distal_length",
"pendant_length"]
but this is per run and not per placement.

I therefore came up with this PR, that should ensure that placements are read and stored in a specified field order, i.e. rearranges if necessary.

Unfortunately, the current tests fail - but I think this is not due to this PR but a more general issue, see #67

@sjanssen2 sjanssen2 requested a review from antgonza November 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant