skylark: Require visibility for drake_cc_package_library (RobotLocomo…

…tion#13701)

Using an implicit visibility that differs from the package(default_visibility)
is too confusing.

attic/manipulation/planner/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "planner",
+    visibility = ["//visibility:public"],
     deps = [
         ":rbt_differential_inverse_kinematics",
     ],

attic/multibody/BUILD.bazel

@@ -18,6 +18,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "multibody",
+    visibility = ["//visibility:public"],
     deps = [
         ":approximate_ik",
         ":global_inverse_kinematics",

attic/multibody/collision/BUILD.bazel

@@ -15,6 +15,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "collision",
+    visibility = ["//visibility:public"],
     deps = [
         ":bullet_collision",
         ":collision_api",

attic/multibody/joints/BUILD.bazel

@@ -15,6 +15,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "joints",
+    visibility = ["//visibility:public"],
     deps = [
         ":everything",
     ],

attic/multibody/parsers/BUILD.bazel

@@ -16,6 +16,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "parsers",
+    visibility = ["//visibility:public"],
     deps = [
         ":find_files",
         ":parsing",

attic/multibody/shapes/BUILD.bazel

@@ -15,6 +15,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "shapes",
+    visibility = ["//visibility:public"],
     deps = [
         ":everything",
     ],

attic/systems/controllers/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "controllers",
+    visibility = ["//visibility:public"],
     deps = [
         ":rbt_inverse_dynamics",
         ":rbt_inverse_dynamics_controller",

attic/systems/rendering/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "rendering",
+    visibility = ["//visibility:public"],
     deps = [
         ":drake_visualizer_client",
     ],

attic/systems/sensors/BUILD.bazel

@@ -14,6 +14,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "sensors",
+    visibility = ["//visibility:public"],
     deps = [
         ":accelerometer",
         ":depth_sensor",

attic/systems/trajectory_optimization/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "trajectory_optimization",
+    visibility = ["//visibility:public"],
     deps = [
         ":generalized_constraint_force_evaluator",
         ":joint_limit_constraint_force_evaluator",

attic/util/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "util",
+    visibility = ["//visibility:public"],
     deps = [
         ":everything",
     ],

common/BUILD.bazel

@@ -20,6 +20,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "common",
+    visibility = ["//visibility:public"],
     deps = [
         ":autodiff",
         ":autodiffxd_make_coherent",

common/proto/BUILD.bazel

@@ -19,6 +19,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "proto",
+    visibility = ["//visibility:public"],
     deps = [
         ":call_python",
         ":rpc_pipe_temp_directory",

common/test_utilities/BUILD.bazel

@@ -23,6 +23,7 @@ exports_files([
 drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
+    visibility = ["//visibility:public"],
     deps = [
         ":eigen_geometry_compare",
         ":eigen_matrix_compare",

common/trajectories/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "trajectories",
+    visibility = ["//visibility:public"],
     deps = [
         ":bspline_trajectory",
         ":discrete_time_trajectory",

common/yaml/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "yaml",
+    visibility = ["//visibility:public"],
     deps = [
         ":yaml_read_archive",
         ":yaml_write_archive",

geometry/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "geometry",
+    visibility = ["//visibility:public"],
     deps = [
         ":frame_kinematics",
         ":geometry_frame",

geometry/proximity/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "proximity",
+    visibility = ["//visibility:public"],
     deps = [
         ":bounding_volume_hierarchy",
         ":collision_filter_legacy",

geometry/query_results/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "query_results",
+    visibility = ["//visibility:public"],
     deps = [
         ":contact_surface",
         ":penetration_as_point_pair",

geometry/render/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "render",
+    visibility = ["//visibility:public"],
     deps = [
         ":render_camera",
         ":render_engine",

geometry/render/gl_renderer/BUILD.bazel

@@ -29,6 +29,7 @@ drake_cc_package_library_gl_per_os(
         ":shader_program",
         ":shape_meshes",
     ],
+    visibility = ["//visibility:public"],
 )
 
 drake_cc_library_gl_ubuntu_only(

geometry/render/shaders/BUILD.bazel

@@ -11,6 +11,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "shaders",
+    visibility = ["//visibility:public"],
     deps = [
         ":depth_shaders",
     ],

geometry/test_utilities/BUILD.bazel

@@ -14,6 +14,7 @@ package(default_visibility = ["//visibility:public"])
 drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
+    visibility = ["//visibility:public"],
     deps = [
         ":dummy_render_engine",
         ":geometry_set_tester",

lcm/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "lcm",
+    visibility = ["//visibility:public"],
     deps = [
         ":drake_lcm",
         ":interface",

manipulation/kinova_jaco/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "kinova_jaco",
+    visibility = ["//visibility:public"],
     deps = [
         ":jaco_command_receiver",
         ":jaco_command_sender",

manipulation/kuka_iiwa/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "kuka_iiwa",
+    visibility = ["//visibility:public"],
     deps = [
         ":iiwa_command_receiver",
         ":iiwa_command_sender",

manipulation/perception/BUILD.bazel

@@ -13,6 +13,7 @@ load("//tools/lint:lint.bzl", "add_lint_tests")
 
 drake_cc_package_library(
     name = "perception",
+    visibility = ["//visibility:public"],
     deps = [
         ":optitrack_pose_extractor",
         ":pose_smoother",

manipulation/planner/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "planner",
+    visibility = ["//visibility:public"],
     deps = [
         ":constraint_relaxing_ik",
         ":differential_inverse_kinematics",

manipulation/schunk_wsg/BUILD.bazel

@@ -18,6 +18,7 @@ package(
 
 drake_cc_package_library(
     name = "schunk_wsg",
+    visibility = ["//visibility:public"],
     deps = [
         ":schunk_wsg_constants",
         ":schunk_wsg_controller",

manipulation/util/BUILD.bazel

@@ -27,6 +27,7 @@ drake_py_library(
 
 drake_cc_package_library(
     name = "util",
+    visibility = ["//visibility:public"],
     deps = [
         ":bot_core_lcm_encode_decode",
         ":move_ik_demo_base",

math/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "math",
+    visibility = ["//visibility:public"],
     deps = [
         ":autodiff",
         ":barycentric",

multibody/benchmarks/acrobot/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "acrobot",
+    visibility = ["//visibility:public"],
     deps = [
         ":analytical_acrobot",
         ":make_acrobot_plant",

multibody/benchmarks/free_body/BUILD.bazel

@@ -24,6 +24,7 @@ filegroup(
 
 drake_cc_package_library(
     name = "free_body",
+    visibility = ["//visibility:public"],
     deps = [
         ":free_body_only",
     ],

multibody/benchmarks/inclined_plane/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:private"])
 
 drake_cc_package_library(
     name = "inclined_plane",
+    visibility = ["//visibility:public"],
     deps = [
         ":inclined_plane_plant",
     ],

multibody/benchmarks/kuka_iiwa_robot/BUILD.bazel

@@ -14,6 +14,7 @@ package(default_visibility = ["//visibility:private"])
 
 drake_cc_package_library(
     name = "kuka_iiwa_robot",
+    visibility = ["//visibility:public"],
     deps = [
         ":make_kuka_iiwa_model",
     ],

multibody/benchmarks/mass_damper_spring/BUILD.bazel

@@ -14,6 +14,7 @@ package(default_visibility = ["//visibility:private"])
 
 drake_cc_package_library(
     name = "mass_damper_spring",
+    visibility = ["//visibility:public"],
     deps = [
         ":mass_damper_spring_analytical_solution",
     ],

multibody/benchmarks/pendulum/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:private"])
 
 drake_cc_package_library(
     name = "pendulum",
+    visibility = ["//visibility:public"],
     deps = [
         ":make_pendulum_plant",
     ],

multibody/constraint/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "constraint",
+    visibility = ["//visibility:public"],
     deps = [
         ":constraint_problem_data",
         ":constraint_solver",

multibody/hydroelastics/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "hydroelastics",
+    visibility = ["//visibility:public"],
     deps = [
         ":contact_surface_from_level_set",
         ":hydroelastic_engine",

multibody/inverse_kinematics/BUILD.bazel

@@ -15,6 +15,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "inverse_kinematics",
+    visibility = ["//visibility:public"],
     deps = [
         ":inverse_kinematics_core",
         ":kinematic_constraint",

multibody/math/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "math",
+    visibility = ["//visibility:public"],
     deps = [
         ":spatial_acceleration",
         ":spatial_algebra",

multibody/optimization/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "optimization",
+    visibility = ["//visibility:public"],
     deps = [
         ":contact_wrench",
         ":contact_wrench_evaluator",

multibody/plant/BUILD.bazel

@@ -15,6 +15,7 @@ package(
 
 drake_cc_package_library(
     name = "plant",
+    visibility = ["//visibility:public"],
     deps = [
         ":calc_distance_and_time_derivative",
         ":contact_jacobians",

multibody/tree/BUILD.bazel

@@ -14,6 +14,7 @@ package(
 
 drake_cc_package_library(
     name = "tree",
+    visibility = ["//visibility:public"],
     deps = [
         ":articulated_body_inertia",
         ":multibody_element",

multibody/triangle_quadrature/BUILD.bazel

@@ -15,6 +15,7 @@ package(
 
 drake_cc_package_library(
     name = "triangle_quadrature",
+    visibility = ["//visibility:public"],
     deps = [
         ":triangle_quadrature_routine",
         ":triangle_quadrature_rules",

perception/BUILD.bazel

@@ -13,6 +13,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "perception",
+    visibility = ["//visibility:public"],
     deps = [
         ":depth_image_to_point_cloud",
         ":point_cloud",

solvers/BUILD.bazel

@@ -19,6 +19,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "solvers",
+    visibility = ["//visibility:public"],
     deps = [
         ":bilinear_product_util",
         ":binding",

solvers/fbstab/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "fbstab",
+    visibility = ["//visibility:public"],
     deps = [
         ":fbstab_algorithm",
         ":fbstab_dense",

solvers/test_utilities/BUILD.bazel

@@ -14,6 +14,7 @@ package(default_visibility = ["//visibility:public"])
 drake_cc_package_library(
     name = "test_utilities",
     testonly = 1,
+    visibility = ["//visibility:public"],
     deps = [
         ":check_constraint_eval_nonsymbolic",
     ],

systems/analysis/BUILD.bazel

@@ -12,6 +12,7 @@ package(default_visibility = ["//visibility:public"])
 
 drake_cc_package_library(
     name = "analysis",
+    visibility = ["//visibility:public"],
     deps = [
         ":antiderivative_function",
         ":bogacki_shampine3_integrator",