Skip to content

Commit

Permalink
Slice filter: clear original Accept-Ranges.
Browse files Browse the repository at this point in the history
The slice filter allows ranges for the response by setting the r->allow_ranges
flag, which enables the range filter.  If the range was not requested, the
range filter adds an Accept-Ranges header to the response to signal the
support for ranges.

Previously, if an Accept-Ranges header was already present in the first slice
response, client received two copies of this header.  Now, the slice filter
removes the Accept-Ranges header from the response prior to setting the
r->allow_ranges flag.
  • Loading branch information
arut committed Jul 9, 2020
1 parent 826fb0d commit 5cef7de
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/http/modules/ngx_http_slice_filter_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ ngx_http_slice_header_filter(ngx_http_request_t *r)
r->headers_out.content_range->hash = 0;
r->headers_out.content_range = NULL;

if (r->headers_out.accept_ranges) {
r->headers_out.accept_ranges->hash = 0;
r->headers_out.accept_ranges = NULL;
}

r->allow_ranges = 1;
r->subrequest_ranges = 1;
r->single_range = 1;
Expand Down

0 comments on commit 5cef7de

Please sign in to comment.