Warn when using deprecated egrep/fgrep.

qinwentu · Dec 31, 2016 · e679ff2 · e679ff2
1 parent 30e94ea
commit e679ff2
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/ShellCheck/Checks/Commands.hs b/ShellCheck/Checks/Commands.hs
@@ -83,6 +83,8 @@ commandChecks = [
     ,checkTimedCommand
     ,checkLocalScope
     ,checkDeprecatedTempfile
+    ,checkDeprecatedEgrep
+    ,checkDeprecatedFgrep
     ]
 
 buildCommandMap :: [CommandCheck] -> Map.Map CommandName (Token -> Analysis)
@@ -667,5 +669,13 @@ prop_checkDeprecatedTempfile2 = verifyNot checkDeprecatedTempfile "tempfile=$(mk
 checkDeprecatedTempfile = CommandCheck (Basename "tempfile") $
     \t -> warn (getId t) 2186 "tempfile is deprecated. Use mktemp instead."
 
+prop_checkDeprecatedEgrep = verify checkDeprecatedEgrep "egrep '.+'"
+checkDeprecatedEgrep = CommandCheck (Basename "egrep") $
+    \t -> info (getId t) 2196 "egrep is non-standard and deprecated. Use grep -E instead."
+
+prop_checkDeprecatedFgrep = verify checkDeprecatedFgrep "fgrep '*' files"
+checkDeprecatedFgrep = CommandCheck (Basename "fgrep") $
+    \t -> info (getId t) 2197 "fgrep is non-standard and deprecated. Use grep -F instead."
+
 return []
 runTests =  $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])