Skip to content

Commit

Permalink
datapath-windows: remove ASSERT in OvsDoFlowLookupOutput()
Browse files Browse the repository at this point in the history
We needed this ASSERT earlier to catch unexpected cases. This code seems
to be fairly stable, and we can remove the ASSERT.

It is annoying to be hitting this ASSERT while changing the internal
adapter properties.

Signed-off-by: Nithin Raju <[email protected]>
Acked-by: Alin Gabriel Serdean <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
nithinrajub authored and blp committed Dec 15, 2015
1 parent 5d8b248 commit 398e182
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion datapath-windows/ovsext/Actions.c
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,6 @@ OvsDoFlowLookupOutput(OvsForwardingContext *ovsFwdCtx)
POVS_VPORT_ENTRY vport =
OvsFindVportByPortNo(ovsFwdCtx->switchContext, ovsFwdCtx->srcVportNo);
if (vport == NULL || vport->ovsState != OVS_STATE_CONNECTED) {
ASSERT(FALSE); // XXX: let's catch this for now
OvsCompleteNBLForwardingCtx(ovsFwdCtx,
L"OVS-Dropped due to internal/tunnel port removal");
ovsActionStats.noVport++;
Expand Down

0 comments on commit 398e182

Please sign in to comment.