Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notebooks refering to removed service #6580

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

NoureldinYosri
Copy link
Collaborator

These notebook explain the floquet service which has been recently removed.

@NoureldinYosri NoureldinYosri requested review from vtomole, cduck and a team as code owners May 1, 2024 00:04
@NoureldinYosri NoureldinYosri requested a review from dabacon May 1, 2024 00:04
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NoureldinYosri NoureldinYosri requested a review from senecameeks May 1, 2024 00:05
Copy link
Collaborator

@senecameeks senecameeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some references that need to be removed for the CI to pass

@CirqBot CirqBot added the size: XL lines changed >1000 label May 5, 2024
@github-actions github-actions bot added the Stale label Jun 5, 2024
@github-actions github-actions bot closed this Jul 5, 2024
@NoureldinYosri NoureldinYosri reopened this Jul 5, 2024
@github-actions github-actions bot removed the Stale label Jul 6, 2024
@github-actions github-actions bot added the Stale label Aug 5, 2024
@github-actions github-actions bot closed this Sep 4, 2024
@mhucka mhucka added the status/stale This has been closed due to inactivity for an extended period of time. label Nov 18, 2024
@mhucka mhucka reopened this Dec 20, 2024
@github-actions github-actions bot removed the status/stale This has been closed due to inactivity for an extended period of time. label Dec 21, 2024
@dstrain115
Copy link
Collaborator

@NoureldinYosri @senecameeks Can we finish this PR off and remove these notebooks? Calibration API was deleted some time ago, and we should remove or augment this documentation.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (988ecbc) to head (f896828).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6580   +/-   ##
=======================================
  Coverage   97.86%   97.87%           
=======================================
  Files        1084     1084           
  Lines       94408    94408           
=======================================
+ Hits        92393    92398    +5     
+ Misses       2015     2010    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) January 14, 2025 20:12
@NoureldinYosri NoureldinYosri merged commit cd9a3ff into quantumlib:main Jan 14, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants