Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exponent location on classically controlled diagrams #6897

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Dec 30, 2024

The original implementation seems to have assumed the classical conditions were prepended to the wire symbols, not appended.

fixes #6814

The original implementation seems to have assumed the classical conditions were prepended to the wire symbols, not appended.
@daxfohl daxfohl requested review from vtomole and a team as code owners December 30, 2024 04:16
@daxfohl daxfohl requested a review from mpharrigan December 30, 2024 04:16
@CirqBot CirqBot added the size: M 50< lines changed <250 label Dec 30, 2024
@mpharrigan mpharrigan enabled auto-merge (squash) December 30, 2024 19:07
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (06f12b9) to head (041a7ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6897   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1084     1084           
  Lines       94225    94235   +10     
=======================================
+ Hits        92215    92225   +10     
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpharrigan mpharrigan merged commit 32bf399 into quantumlib:main Jan 2, 2025
37 checks passed
@daxfohl daxfohl deleted the fix-classical-diagram-exponents branch January 10, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit text diagram broken for a circuit involving both **0.5 and classical conditioning
3 participants