Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check/nbformat installation and execution #7004

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jan 30, 2025

  • Fail early if tensorflow-docs installation is broken.
  • Use exit status from the nbfmt tool to decide if the format is good.
  • Bump up tensorflow-docs to be compatible with protobuf-4
  • Reformat notebooks which slipped through broken check/nbformat.

Fixes #7002

@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (0e5df4e) to head (2008a73).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7004      +/-   ##
==========================================
- Coverage   97.89%   97.89%   -0.01%     
==========================================
  Files        1085     1085              
  Lines       95098    95098              
==========================================
- Hits        93096    93094       -2     
- Misses       2002     2004       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
markoburcul Marko Burčul
- Fail early if tensorflow-docs installation is broken.
- Use exit status from the nbfmt tool to decide if the format is good.

Verified

This commit was signed with the committer’s verified signature.
markoburcul Marko Burčul

Verified

This commit was signed with the committer’s verified signature.
markoburcul Marko Burčul
Executed  check/nbformat --apply
@pavoljuhas pavoljuhas force-pushed the fix-check_nbformat-script branch from 3eaae6c to 2008a73 Compare January 30, 2025 02:30
@pavoljuhas pavoljuhas marked this pull request as ready for review January 30, 2025 02:32
@pavoljuhas pavoljuhas requested a review from mhucka January 30, 2025 02:34
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Jan 30, 2025
Merged via the queue into quantumlib:main with commit 6ebc78b Jan 30, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the fix-check_nbformat-script branch January 30, 2025 07:33
mhucka pushed a commit to mhucka/Cirq that referenced this pull request Jan 30, 2025

Verified

This commit was signed with the committer’s verified signature.
markoburcul Marko Burčul
* Improve the check/nbformat script

- Fail early if tensorflow-docs installation is broken.
- Use exit status from the nbfmt tool to decide if the format is good.

* Bump up tensorflow-docs to be compatible with protobuf-4

* Format jupyter notebooks

Executed  check/nbformat --apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix check/nbformat and format notebooks
3 participants