-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symbolic scalars in linear combinations #7030
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7030 +/- ##
==========================================
- Coverage 97.89% 97.88% -0.01%
==========================================
Files 1085 1085
Lines 95188 95199 +11
==========================================
+ Hits 93181 93190 +9
- Misses 2007 2009 +2 ☔ View full report in Codecov by Sentry. |
@pavoljuhas is there a workaround for the coverage check on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a tiny adjustment to typing. I will take a look at the coverage noise separately.
Thanks for adding this!
This gets fixed by moving coverage configuration to pyproject.toml - #7038 (comment) |
Co-authored-by: Pavol Juhas <[email protected]>
Followup to #7003, allowing symbolic scalars in
LinearCombinationOfGates
andLinearCombinationOfOps
.Applies to #1617.