Fix symbolic call graphs for factoring phase estimates #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fpapa250
commented
Nov 13, 2024
•
fpapa250
commented
- Adds symbolic type checking for remaining ECC bloqs (Change all integer arguments in FindECCPrivateKey bloq (and downstream bloqs) to SymbolicInt #1476)
- Adds DecomposeTypeErrors for bloqs which can't be symbolically decomposed
- Both call graphs for factoring phase estimates work for symbolic arguments
- Adds decomposition for MeasureQFT bloq to allow for call graphs of the phase estimation bloqs
| @@ -30,8 +46,21 @@ class MeasureQFT(Bloq): | |||
| def signature(self) -> 'Signature': | |||
| return Signature([Register('x', QBit(), shape=(self.n,), side=Side.LEFT)]) | |||
|
|
|||
| def decompose_bloq(self) -> 'CompositeBloq': | |||
| raise DecomposeTypeError('MeasureQFT is a placeholder, atomic bloq.') | |||
| def build_composite_bloq(self, bb: 'BloqBuilder', x: Soquet) -> Dict[str, 'SoquetT']: | |||
There was a problem hiding this comment.
since this shim has a decomposition now should it become a bloq ?
There was a problem hiding this comment.
I'll leave that up to @mpharrigan. We added this decomposition a few PRs back (or meant to), but it got clobbered when merging two separate PRs touching this file (my mistake). I think the goal eventually is to use the phase_estimation bloqs, but for now I just added this so it could decompose entirely into leaf bloqs.
NoureldinYosri
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.