Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for computing expectation values. #248

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Add API for computing expectation values. #248

merged 4 commits into from
Dec 4, 2020

Conversation

sergeisakov
Copy link
Collaborator

Closes #238

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Dec 3, 2020
95-martin-orion
95-martin-orion requested changes Dec 4, 2020
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass: expect.h and simulator_basic.h. I'll go over AVX/SSE as well, but I expect my comments will be similar.

lib/simulator_basic.h Outdated Show resolved Hide resolved
lib/simulator_basic.h Show resolved Hide resolved
lib/simulator_basic.h Show resolved Hide resolved
lib/simulator_basic.h Show resolved Hide resolved
lib/expect.h Show resolved Hide resolved
lib/expect.h Outdated Show resolved Hide resolved
lib/expect.h Outdated Show resolved Hide resolved
lib/expect.h Show resolved Hide resolved
@95-martin-orion 95-martin-orion mentioned this pull request Dec 4, 2020
Open
@95-martin-orion
Copy link
Collaborator

Having skimmed through the AVX and SSE changes, I can see how templating the ExpectationValue* methods could easily become complicated. Instead, I've updated #227 with a TODO to (eventually) publish the script that generated this code.

@sergeisakov sergeisakov added the kokoro:run Trigger Kokoro builds for this PR. label Dec 4, 2020
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Dec 4, 2020
@sergeisakov sergeisakov merged commit ac575fa into master Dec 4, 2020
@sergeisakov sergeisakov deleted the expectation-value branch December 4, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide an API for finding expectation values
3 participants
@sergeisakov @95-martin-orion @qsim-qsimh-bot